-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reschedule changed devices #333
Reschedule changed devices #333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 98.19% 98.20%
=======================================
Files 64 64
Lines 7922 7926 +4
=======================================
+ Hits 7779 7783 +4
Misses 143 143 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this does fix the issue with rescheduling devices and works as intended. so that is a +1 from me.
As for the question about the information logged someone else needs to take a decision on that part
This will be used to reschedule their jobs to be correctly according to changes
This is simply done by deleting the current jobs and adding new ones
be3c87a
to
74b54fe
Compare
|
Scope and purpose
Fixes #330.
Makes
load_polldevs
detect changed devices and then deletes scheduled jobs for these and adds new jobs with the new configuration values.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.