fix: move user prop updater into statsigProvider #7442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
just-toby
commented
Oct 10, 2023
| @@ -122,53 +120,6 @@ export default function App() { | |||
| } | |||
| }, [searchParams, setShouldDisableNFTRoutes]) | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
all this code is just relocated and unchanged
2 flaky tests on run #14959 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| UniswapX Toggle > prompts opt-in if UniswapX is better |
Output
Screenshots
|
|
| UniswapX activity history > can view UniswapX order status progress in activity |
Output
Screenshots
|
|
Review all test suite changes for PR #7442 ↗︎
mattbspector
approved these changes
Oct 11, 2023
tinaszheng
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moves all the
useEffecthooks which set user properties into their own component. this is important because it puts the logic within StatsigProvider and DarkModeQueryParamProvider, which can affect the values we set.Slack thread: https://uniswapteam.slack.com/archives/C052XQ3EUTT/p1696973999717179
Test plan
manually verified that
isUniswapXDefaultEnabledcorrectly updates totrueat this callsite now - before it was never updating to the correct value