Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): C APIのテストがWindowsで壊れているのを直す #885

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(test): C APIのテストがWindowsで壊れているのを直す #885

merged 2 commits into from
Dec 3, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Dec 3, 2024

内容

関連 Issue

その他

@qryxip
Copy link
Member Author

qryxip commented Dec 3, 2024 •
edited
Loading

https://github.com/qryxip/voicevox_core/actions/runs/12144077709
❌

@qryxip qryxip mentioned this pull request Dec 3, 2024
Merged
@qryxip qryxip force-pushed the fix-test-fix-c-api-tests-for-windows branch from fa2a64a to 0ebdffc Compare December 3, 2024 17:09
@qryxip
Copy link
Member Author

qryxip commented Dec 3, 2024

https://github.com/qryxip/voicevox_core/actions/runs/12144667205

@qryxip qryxip requested a review from Hiroshiba December 3, 2024 17:10
Hiroshiba
Hiroshiba approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for reviewで良い感じでしょうか 👀

よくわからないけどLGTM！！

@qryxip
Copy link
Member Author

qryxip commented Dec 3, 2024

問題のテストが通ったっぽいのでマージしようと思います。

@qryxip qryxip marked this pull request as ready for review December 3, 2024 17:32
@qryxip qryxip merged commit 7282e09 into VOICEVOX:main Dec 3, 2024
19 checks passed
@qryxip qryxip deleted the fix-test-fix-c-api-tests-for-windows branch December 3, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba