fos_js_routes is no longer suffixed in prod environment #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the existing suffix is kept but deprecated
lib/capistrano/tasks/assets.rake
Outdated
| @@ -33,7 +33,8 @@ namespace :fos do | |||
| DESC | |||
| task :dump do | |||
| on roles(:app) do | |||
| execute "cd #{release_path} && php " + fetch(:symfony_console_path) + " --env=prod fos:js-routing:dump --target=web/js/fos_js_routes_prod.js" | |||
| execute "cd #{release_path} && php " + fetch(:symfony_console_path) + " --env=prod fos:js-routing:dump --target=web/js/fos_js_routes.js" | |||
| execute "cp web/js/fos_js_routes.js web/js/fos_js_routes_prod.js" | |||
There was a problem hiding this comment.
@jdubuisson I'm wondering if cd #{release_path} && is required in order to avoid side-effects.
Are we sure that the second line is executed in the same context than the first line? Maybe these commands are executed by separated processes than don't share the same current directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the existing suffix is kept but deprecated.
See Victoire/victoire PR 1052 for the matching change