Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fos_js_routes is no longer suffixed in prod environment #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fos_js_routes is no longer suffixed in prod environment #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f39b5c
fos_js_routes is no longer suffixed in prod environment
Apr 4, 2018
a25f533
script strengthening : working directory
jdubuisson May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/capistrano/tasks/assets.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ namespace :fos do
DESC
task :dump do
on roles(:app) do
execute "cd #{release_path} && php " + fetch(:symfony_console_path) + " --env=prod fos:js-routing:dump --target=web/js/fos_js_routes_prod.js"
execute "cd #{release_path} && php " + fetch(:symfony_console_path) + " --env=prod fos:js-routing:dump --target=web/js/fos_js_routes.js"
execute "cp web/js/fos_js_routes.js web/js/fos_js_routes_prod.js"
Copy link
Member

@alexislefebvre alexislefebvre May 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdubuisson I'm wondering if cd #{release_path} && is required in order to avoid side-effects.

Are we sure that the second line is executed in the same context than the first line? Maybe these commands are executed by separated processes than don't share the same current directory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 better safe than sorry 😃

end
end
end
Expand Down