-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tooltip constant file to store text / tsx content for tooltip across the app. #126
Conversation
onehanddev
commented
Nov 29, 2024
- Implement Scorecard Tab Content with Dynamic Descriptions
- Improves code maintainability by centralizing descriptions in the tooltip.tsx file.
…inside of tooltips in the project, implemented the info popup in the dashboard
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -3,6 +3,8 @@ import * as React from "react"; | |||
|
|||
import { InfoIcon } from "lucide-react"; | |||
|
|||
import { cn } from "@/lib/utils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need of importing cn
if we are not mixing classes
}: PropsWithChildren<{ | ||
title?: string; | ||
classNames?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better className
so we are consistent with the rest of the codebase.
There's a double scrollbar in the dialog of the overview table. |
Ahh, this seems to be one of those screen issues, Can you please share the resolution of your screen, as I cant reproduce it in my screen size with zoomed in/out enabled. |
The latest commit should fix the issue. Can you please check again @andresgnlez |