Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltip constant file to store text / tsx content for tooltip across the app. #126

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

onehanddev
Copy link
Contributor

  • Implement Scorecard Tab Content with Dynamic Descriptions
  • Improves code maintainability by centralizing descriptions in the tooltip.tsx file.

…inside of tooltips in the project, implemented the info popup in the dashboard
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnc-blue-carbon-cost-tool-ghps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 4:13pm

@@ -3,6 +3,8 @@ import * as React from "react";

import { InfoIcon } from "lucide-react";

import { cn } from "@/lib/utils";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need of importing cn if we are not mixing classes

}: PropsWithChildren<{
title?: string;
classNames?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better className so we are consistent with the rest of the codebase.

@agnlez
Copy link
Member

agnlez commented Dec 3, 2024

@onehanddev
image

There's a double scrollbar in the dialog of the overview table.

@onehanddev
Copy link
Contributor Author

@onehanddev image

There's a double scrollbar in the dialog of the overview table.

Ahh, this seems to be one of those screen issues, Can you please share the resolution of your screen, as I cant reproduce it in my screen size with zoomed in/out enabled.

@onehanddev
Copy link
Contributor Author

@onehanddev image
There's a double scrollbar in the dialog of the overview table.

Ahh, this seems to be one of those screen issues, Can you please share the resolution of your screen, as I cant reproduce it in my screen size with zoomed in/out enabled.

The latest commit should fix the issue. Can you please check again @andresgnlez

@agnlez agnlez merged commit 2dc08d3 into dev Dec 3, 2024
3 checks passed
@agnlez agnlez deleted the TBCCT-153-implement-tooltip-content branch December 3, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants