Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltip constant file to store text / tsx content for tooltip across the app. #126

Merged
merged 6 commits into from
Dec 3, 2024
+1,019 −27
Merged

Added tooltip constant file to store text / tsx content for tooltip across the app. #126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7de0790
added tooltip constant file to centralise and store all content used …
Nov 29, 2024
abd756b
fix: addressed PR comments
Dec 3, 2024
b8b0107
fix: added scrollbar, added new content for key costs table, design f…
Dec 3, 2024
a500667
fix: scroll issue for info modal
Dec 3, 2024
ddebdfe
fix: lint
Dec 3, 2024
b921c5a
minor styling updates
agnlez Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion client/src/components/ui/info-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import * as React from "react";

import { InfoIcon } from "lucide-react";

import { cn } from "@/lib/utils";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need of importing cn if we are not mixing classes


import { Button } from "@/components/ui/button";
import {
Dialog,
Expand All @@ -16,8 +18,10 @@ import {
export default function InfoButton({
title,
children,
classNames,
}: PropsWithChildren<{
title?: string;
classNames?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better className so we are consistent with the rest of the codebase.

}>) {
return (
<Dialog>
Expand All @@ -26,7 +30,7 @@ export default function InfoButton({
<InfoIcon className="h-7 w-7 text-foreground hover:text-muted-foreground" />
</Button>
</DialogTrigger>
<DialogContent className="sm:max-w-md">
<DialogContent className={cn(classNames)}>
<DialogHeader>
{title && <DialogTitle>{title}</DialogTitle>}
<DialogContentContainer>{children}</DialogContentContainer>
Expand Down
Loading
Loading