Safe get kotlinVersion #320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greenheart
added a commit
to relate-app/react-native-background-upload
that referenced
this pull request
Jan 24, 2023
cchampou
approved these changes
Apr 28, 2023
|
I'm using this branch on our application it seems to build and work fine ! I'd love to see it merged and published |
|
@cchampou do you have write access? or is the og author AWOL? |
|
Just tacking on that I would love to see this one merged as well. Currently running into the same issue while trying to upgrade to RN 73.x. |
|
Honestly it just seems like we're going to have to use the fixed Branch from @cchampou
instead of relying on the actual project since the owner is not here anymore
…On Fri, Dec 22, 2023, 12:29 daltonwignall ***@***.***> wrote:
Just tacking on that I would love to see this one merged as well.
Currently running into the same issue while trying to upgrade to RN 73.x.
—
Reply to this email directly, view it on GitHub
<#320 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGAT4QO3LHRKBYEWYCIUE3YKXGRVAVCNFSM6AAAAAATCSNJD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXHE3DKOBVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an error on the newer build tools version because Kotlin version was not able to be upgraded and provided to this package from the root of the project.
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md