Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe get kotlinVersion #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Safe get kotlinVersion #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a26068
Safe get kotlinVersion
diegomichell Dec 18, 2022
76a1f52
Move safeExtGet to ext
diegomichell Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
buildscript {
// Simple helper that allows the root project to override versions declared by this library.
ext.safeExtGet = { prop, fallback ->
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

ext {
kotlinVersion = '1.6.0'
buildToolsVersion = '29.0.2'
compileSdkVersion = 29
targetSdkVersion = 29
minSdkVersion = 18
}
ext.kotlinVersion = safeExtGet('kotlinVersion', '1.6.0')
ext.detoxKotlinVersion = ext.kotlinVersion

repositories {
Expand All @@ -26,10 +31,6 @@ def DEFAULT_COMPILE_SDK_VERSION = 28
def DEFAULT_BUILD_TOOLS_VERSION = "28.0.3"
def DEFAULT_TARGET_SDK_VERSION = 28

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
buildToolsVersion safeExtGet('buildToolsVersion', DEFAULT_BUILD_TOOLS_VERSION)
Expand Down