Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes potentially destructive code. #2636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removes potentially destructive code. #2636

wants to merge 1 commit into from

Conversation

afred
Copy link
Contributor

@afred afred commented Aug 24, 2023

  • Removes PBCoreIngester.delete_all method.
  • Modifies PBCoreIngester.load_fixtures to not delete anything.
  • Adds guard clause on PBCoreIngester.load_fixtures that raises an error when run in production.

@afred afred requested a review from foglabs August 24, 2023 19:22
@afred afred force-pushed the remove-delete-methods branch 3 times, most recently from 9e2ab1c to 011964b Compare August 24, 2023 20:29
@afred
Removes potentially destructive code.
a9f4004 
* Removes PBCoreIngester.delete_all method.
* Modifies PBCoreIngester.load_fixtures to not delete anything.
* Adds guard clause on PBCoreIngester.load_fixtures that raises an error
  when run in production.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foglabs foglabs Awaiting requested review from foglabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@afred