Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSISDNUtil updated for resourceInMsisdnFormat #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maheshroshan
Copy link
Contributor

No description provided.

@TelcoGitHubBot
Copy link

SonarQube analysis reported 3 issues

  • MAJOR 2 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.

MSISDN msisdn = parse(msisdnResurce);
isMsisdnFormat = true;
} catch (InvalidMSISDNException ex) {
//Logger.getLogger(MSISDNUtil.class.getName()).log(Level.SEVERE, null, ex);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR This block of commented-out lines of code should be removed. rule


boolean isMsisdnFormat = false;
try {
MSISDN msisdn = parse(msisdnResurce);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Remove this useless assignment to local variable "msisdn". rule
MINOR Remove this unused "msisdn" local variable. rule

@hasitha-sandanuwan
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants