-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSISDNUtil updated for resourceInMsisdnFormat #150
Open
maheshroshan
wants to merge
1
commit into
WSO2Telco:master
Choose a base branch
from
maheshroshan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,54 +3,67 @@ | |
import com.google.i18n.phonenumbers.NumberParseException; | ||
import com.google.i18n.phonenumbers.PhoneNumberUtil; | ||
import com.google.i18n.phonenumbers.Phonenumber.PhoneNumber; | ||
import java.util.logging.Level; | ||
import java.util.logging.Logger; | ||
|
||
/** | ||
* Wrap the google phonenumber utility | ||
* | ||
*/ | ||
public class MSISDNUtil { | ||
PhoneNumberUtil util = null; | ||
{ | ||
util = PhoneNumberUtil.getInstance(); | ||
} | ||
|
||
/** | ||
* parse the given text into phone number using google phonenumber lib. | ||
* it is mandatory to have + sign in the rowmsisdn string. | ||
* @param rowmsisdn | ||
* @return MSISDN | ||
* @throws InvalidMSISDNException | ||
*/ | ||
public MSISDN parse(String rowmsisdn) throws InvalidMSISDNException { | ||
try { | ||
rowmsisdn = appendPlusIfNotExist(rowmsisdn); | ||
PhoneNumber number = util.parse(rowmsisdn, null); | ||
MSISDN msisdn = new MSISDN(number.getCountryCode(), number.getNationalNumber()); | ||
return msisdn; | ||
} catch (NumberParseException e) { | ||
throw new InvalidMSISDNException(Google2InternalErrorMapper.mapErrorType(e.getErrorType()) ); | ||
} | ||
} | ||
|
||
private String appendPlusIfNotExist(String rawmsisdn) { | ||
String formattedNumber = null; | ||
String validationRegex = "tel\\:[a-zA-Z0-9]+"; | ||
|
||
if (rawmsisdn != null && rawmsisdn.matches(validationRegex)) { | ||
StringBuilder builder = new StringBuilder(rawmsisdn); | ||
builder.insert(4, "+"); | ||
formattedNumber = builder.toString(); | ||
} else if (rawmsisdn.contains("etel:")) { | ||
String[] msidn = rawmsisdn.split(":"); | ||
formattedNumber = msidn[0] + "+" + msidn[1]; | ||
} else { | ||
formattedNumber = rawmsisdn; | ||
} | ||
|
||
return formattedNumber; | ||
} | ||
|
||
public boolean resourceInMsisdnFormat(String msisdnResurce) { | ||
return (appendPlusIfNotExist(msisdnResurce) != null ); | ||
|
||
PhoneNumberUtil util = null; | ||
|
||
{ | ||
util = PhoneNumberUtil.getInstance(); | ||
} | ||
|
||
/** | ||
* parse the given text into phone number using google phonenumber lib. it | ||
* is mandatory to have + sign in the rowmsisdn string. | ||
* | ||
* @param rowmsisdn | ||
* @return MSISDN | ||
* @throws InvalidMSISDNException | ||
*/ | ||
public MSISDN parse(String rowmsisdn) throws InvalidMSISDNException { | ||
try { | ||
rowmsisdn = appendPlusIfNotExist(rowmsisdn); | ||
PhoneNumber number = util.parse(rowmsisdn, null); | ||
MSISDN msisdn = new MSISDN(number.getCountryCode(), number.getNationalNumber()); | ||
return msisdn; | ||
} catch (NumberParseException e) { | ||
throw new InvalidMSISDNException(Google2InternalErrorMapper.mapErrorType(e.getErrorType())); | ||
} | ||
} | ||
|
||
private String appendPlusIfNotExist(String rawmsisdn) { | ||
String formattedNumber = null; | ||
String validationRegex = "tel\\:[a-zA-Z0-9]+"; | ||
|
||
if (rawmsisdn != null && rawmsisdn.matches(validationRegex)) { | ||
StringBuilder builder = new StringBuilder(rawmsisdn); | ||
builder.insert(4, "+"); | ||
formattedNumber = builder.toString(); | ||
} else if (rawmsisdn.contains("etel:")) { | ||
String[] msidn = rawmsisdn.split(":"); | ||
formattedNumber = msidn[0] + "+" + msidn[1]; | ||
} else { | ||
formattedNumber = rawmsisdn; | ||
} | ||
|
||
return formattedNumber; | ||
} | ||
|
||
public boolean resourceInMsisdnFormat(String msisdnResurce) { | ||
|
||
boolean isMsisdnFormat = false; | ||
try { | ||
MSISDN msisdn = parse(msisdnResurce); | ||
isMsisdnFormat = true; | ||
} catch (InvalidMSISDNException ex) { | ||
//Logger.getLogger(MSISDNUtil.class.getName()).log(Level.SEVERE, null, ex); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
return isMsisdnFormat; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this useless assignment to local variable "msisdn".
Remove this unused "msisdn" local variable.