Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSISDNUtil updated for resourceInMsisdnFormat #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,54 +3,67 @@
import com.google.i18n.phonenumbers.NumberParseException;
import com.google.i18n.phonenumbers.PhoneNumberUtil;
import com.google.i18n.phonenumbers.Phonenumber.PhoneNumber;
import java.util.logging.Level;
import java.util.logging.Logger;

/**
* Wrap the google phonenumber utility
*
*/
public class MSISDNUtil {
PhoneNumberUtil util = null;
{
util = PhoneNumberUtil.getInstance();
}

/**
* parse the given text into phone number using google phonenumber lib.
* it is mandatory to have + sign in the rowmsisdn string.
* @param rowmsisdn
* @return MSISDN
* @throws InvalidMSISDNException
*/
public MSISDN parse(String rowmsisdn) throws InvalidMSISDNException {
try {
rowmsisdn = appendPlusIfNotExist(rowmsisdn);
PhoneNumber number = util.parse(rowmsisdn, null);
MSISDN msisdn = new MSISDN(number.getCountryCode(), number.getNationalNumber());
return msisdn;
} catch (NumberParseException e) {
throw new InvalidMSISDNException(Google2InternalErrorMapper.mapErrorType(e.getErrorType()) );
}
}

private String appendPlusIfNotExist(String rawmsisdn) {
String formattedNumber = null;
String validationRegex = "tel\\:[a-zA-Z0-9]+";

if (rawmsisdn != null && rawmsisdn.matches(validationRegex)) {
StringBuilder builder = new StringBuilder(rawmsisdn);
builder.insert(4, "+");
formattedNumber = builder.toString();
} else if (rawmsisdn.contains("etel:")) {
String[] msidn = rawmsisdn.split(":");
formattedNumber = msidn[0] + "+" + msidn[1];
} else {
formattedNumber = rawmsisdn;
}

return formattedNumber;
}

public boolean resourceInMsisdnFormat(String msisdnResurce) {
return (appendPlusIfNotExist(msisdnResurce) != null );

PhoneNumberUtil util = null;

{
util = PhoneNumberUtil.getInstance();
}

/**
* parse the given text into phone number using google phonenumber lib. it
* is mandatory to have + sign in the rowmsisdn string.
*
* @param rowmsisdn
* @return MSISDN
* @throws InvalidMSISDNException
*/
public MSISDN parse(String rowmsisdn) throws InvalidMSISDNException {
try {
rowmsisdn = appendPlusIfNotExist(rowmsisdn);
PhoneNumber number = util.parse(rowmsisdn, null);
MSISDN msisdn = new MSISDN(number.getCountryCode(), number.getNationalNumber());
return msisdn;
} catch (NumberParseException e) {
throw new InvalidMSISDNException(Google2InternalErrorMapper.mapErrorType(e.getErrorType()));
}
}

private String appendPlusIfNotExist(String rawmsisdn) {
String formattedNumber = null;
String validationRegex = "tel\\:[a-zA-Z0-9]+";

if (rawmsisdn != null && rawmsisdn.matches(validationRegex)) {
StringBuilder builder = new StringBuilder(rawmsisdn);
builder.insert(4, "+");
formattedNumber = builder.toString();
} else if (rawmsisdn.contains("etel:")) {
String[] msidn = rawmsisdn.split(":");
formattedNumber = msidn[0] + "+" + msidn[1];
} else {
formattedNumber = rawmsisdn;
}

return formattedNumber;
}

public boolean resourceInMsisdnFormat(String msisdnResurce) {

boolean isMsisdnFormat = false;
try {
MSISDN msisdn = parse(msisdnResurce);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Remove this useless assignment to local variable "msisdn". rule
MINOR Remove this unused "msisdn" local variable. rule

isMsisdnFormat = true;
} catch (InvalidMSISDNException ex) {
//Logger.getLogger(MSISDNUtil.class.getName()).log(Level.SEVERE, null, ex);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR This block of commented-out lines of code should be removed. rule

}
return isMsisdnFormat;
}
}