Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pool manager cleanup #350

Merged
merged 8 commits into from
May 3, 2024

chore: cleanup after merge

5e487cc
Select commit
Loading
Failed to load commit list.
Merged

refactor: pool manager cleanup #350

chore: cleanup after merge
5e487cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 3, 2024 in 0s

90.55% (+0.45%) compared to 0f77427

View this Pull Request on Codecov

90.55% (+0.45%) compared to 0f77427

Details

Codecov Report

Attention: Patch coverage is 94.57901% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 90.55%. Comparing base (0f77427) to head (5e487cc).
Report is 1 commits behind head on release/v2_contracts.

Files Patch % Lines
...ontracts/liquidity_hub/pool-manager/src/helpers.rs 70.93% 25 Missing ⚠️
...ontracts/liquidity_hub/pool-manager/src/queries.rs 87.03% 7 Missing ⚠️
...quidity_hub/pool-manager/src/liquidity/commands.rs 91.42% 3 Missing ⚠️
...acts/liquidity_hub/pool-manager/src/tests/suite.rs 89.65% 3 Missing ⚠️
...ty_hub/pool-manager/src/tests/integration_tests.rs 99.60% 2 Missing ⚠️
...ntracts/liquidity_hub/pool-manager/src/contract.rs 97.05% 1 Missing ⚠️
...liquidity_hub/pool-manager/src/manager/commands.rs 95.00% 1 Missing ⚠️
contracts/liquidity_hub/pool-manager/src/math.rs 0.00% 1 Missing ⚠️
.../liquidity_hub/pool-manager/src/router/commands.rs 95.45% 1 Missing ⚠️
...ts/liquidity_hub/pool-manager/src/swap/commands.rs 96.42% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           release/v2_contracts     #350      +/-   ##
========================================================
+ Coverage                 90.09%   90.55%   +0.45%     
========================================================
  Files                       278      276       -2     
  Lines                     29604    29921     +317     
========================================================
+ Hits                      26673    27095     +422     
+ Misses                     2931     2826     -105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov