-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Patch boost install checksum mismatch error #57658
build: Patch boost install checksum mismatch error #57658
Conversation
Apply the workaround provided by the React Native community to address a checksum mismatch error that occurs when installing `boost`. The error originates from issues with the `boost` host, JFrog. facebook/react-native#42180
ebc14a7
to
7c3b686
Compare
It appears the CI is currently failing due to the patch being corrupt or not installable. Investigating...
|
23a2c71
to
d3421bb
Compare
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
0b957a9
to
e37d869
Compare
Upgrading to There are two remaining non-required CI failures for checking Node.js versions on windows-latest (#), but they may not be related. It may be just as straightforward to wait until the RN 0.71 patch itself is introduced, rather than upgrade patch-package for the whole Gutenberg repo. I do think there is value in upgrading patch-package from 6.2.2 to 8.0.0 as was done in this PR, as eventually we would run into this bug again if ever using multiple patches in the future. |
For reference, the fix for the
I agree, we might run in a similar situation in the future, so I'd also advocate upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
There are two remaining non-required CI failures for checking Node.js versions on windows-latest (#), but they may not be related.
Yep, they seem unrelated to the changes introduced in this PR, so I've re-run them. Once they succeed, we could merge the PR.
All CI checks passed, I'll proceed with the merge to prevent the CI job |
What?
Fix a install error for
boost
.Why?
The error prevents successful project builds both locally and on CI servers.
How?
Apply the workaround provided by the React Native community to address a
checksum mismatch error that occurs when installing
boost
. The errororiginates from issues with the
boost
host, JFrog.facebook/react-native#42180
Testing Instructions
Verify CI tasks succeed.
Testing Instructions for Keyboard
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.