[RNMobile] Upgrade React Native to version 0.71.15 #57667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Build Tooling
2 tasks
The modifications were automatically made when installing pods.
fluiddot
force-pushed
the
rnmobile/upgrade/react-native-0.71.15
branch
from
5684fe1 to
11899fc
Compare
|
Size Change: +175 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
I updated the |
|
Hi, I noticed you're having issues with upgrading React Native. I've managed to upgrade my app to 0.72.3 with some effort. I posted a tweet here about it, and happy to share the git diff of my changes if that helps (I can't post it here as it's a paid product but I'm happy to walk you through the code on a call at no cost) |
Thank you, @paulmbw, for sharing this valuable information and for your willingness to assist 🙇. The integration of React Native into the Gutenberg project exhibits a slightly different and more complex structure compared to a typical React Native app. Throughout our previous upgrades, we have encountered various blockers, and it is likely that the issue mentioned in this comment is related to the unique integration of React Native. My purpose with this PR was mainly to test the waters and check if we could quickly apply the patch version. However, as shared above, it appears that this is not the case. Hence, we've decided to temporarily halt our efforts and plan to revisit this matter upon upgrading to version 0.72.3. |
The workaround solves the issue related to redefining `clockid_t` in the pod `RCT-Folly`.
I investigated the issue further and managed to apply a workaround in b72f56a. More details can be found in the PR's description. |
This was referenced Jan 17, 2024
fluiddot
commented
Jan 17, 2024
There was a problem hiding this comment.
These changes have been introduced in React Native version 0.71.14 as part of an Xcode 15 patch.
geriux
approved these changes
Jan 17, 2024
10 tasks
|
Heads up that I've just added the following warning to the PR's description: Warning Usually, in React Native upgrades we also update the version in |
# Conflicts: # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock
# Conflicts: # package-lock.json # packages/react-native-editor/ios/Podfile.lock
This update was already made in 66fa7bc but we to apply it again after updating with `trunk`.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
Upgrade React Native to version 0.71.15.
Why?
How?
Podfile.lockby runningnpm run native preios.react-nativepatch file.Warning
Usually, in React Native upgrades we also update the version in
react-native-libraries-publisherto generate new Android binaries. However, since this upgrade is for a patch version, we assume all third-party libraries support any patch version of0.71. For this reason, this step has been skipped.Address build failure related to
RCT-FollyThis is related to the issue shared in #57667 (comment). I investigated the problem further and found a workaround.
For some reason,
RCT-Follyredefinesclockid_t, however, this seems not needed in newer iOS SDK versions. This was been fixed inRCT-Follyversion (v2022.08.29.00- facebook/folly@4a2410f) but current React Native version points to an older version (2021.07.22.00- reference). The version has been bumped in React Native version 0.73.0 (2022.05.16.00- reference), so we'd need to keep the patch until we upgrade.Regarding the patch, this is the part we need from
react_native_podsscript (reference) that removes the condition related to checking the minimum version required (reference):Testing Instructions
Note
It's recommended to use the following installable builds for testing:
Nothing in particular, it should be enough by smoke testing the editor.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A