-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-1729 Prepare for react-dart 7.0.0 #846
Conversation
This behavior changes in react-dart 7.0.0 to throw instead of returning null. Since we didn't ever need to support unmounted components in the first place, we'll just remove the tests.
This eliminates JS interop logic that was duplicated from react-dart, which relied on APIs removed in react-dart 7.0.0, and in general was at risk of getting out of sync. These changes were backported from the null-safety branch.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
…eact 7.0.0 The existing lack of a default was also bad behavior, since passing `null` as children would break.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+10 (passing CI)
ReactElement build(Map props, [List childrenArgs]) { | ||
ReactElement build(Map props, [List childrenArgs = const []]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
The not-yet-released react-dart 7.0.0 contains breaking changes that will need to be addressed in over_react before it's compatible.
We'll be making these compatibility changes proactively in order to make testing of the WIP react-dart 7.0.0 branch easier, and also to validate that we won't hit any blockers that require tweaks to the major changes in react-dart 7.0.0.
This PR won't be raising the upper bound of over_react's react-dart dependency, but once react-dart 7.0.0 is released, there shouldn't be any additional code changes necessary to raise that upper bound.
Changes
react.main
to usereact.htmlMain
forwardRef
is deprecated, and will be removed in the next major, along with this copyRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: