Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-1729 Prepare for react-dart 7.0.0 #846

Merged
merged 7 commits into from
Oct 11, 2023
Merged

FED-1729 Prepare for react-dart 7.0.0 #846

merged 7 commits into from
Oct 11, 2023

Commits on Oct 6, 2023

  1. Add internal copy of forwardRef, removed from react-dart 7.0.0

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a5a0f83 View commit details
    Browse the repository at this point in the history

  2. Remove tests that rely on jsThis being null in unmounted components 

    This behavior changes in react-dart 7.0.0 to throw instead of
returning null.

Since we didn't ever need to support unmounted components in the first
place, we'll just remove the tests.
    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b426270 View commit details
    Browse the repository at this point in the history

  3. Reuse jsifyPropTypes super logic to avoid reimplementing JS interop 

    This eliminates JS interop logic that was duplicated from react-dart,
which relied on APIs removed in react-dart 7.0.0, and in general was at
risk of getting out of sync.

These changes were backported from the null-safety branch.
    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    028ff4d View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @greglittlefield-wf
    greglittlefield-wf committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1844351 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Fix invalid_override_different_default_values_positional warning w/ r… 

    …eact 7.0.0

The existing lack of a default was also bad behavior, since passing
`null` as children would break.
    @greglittlefield-wf
    greglittlefield-wf committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ab42a4d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Bump lower bound of react to version that adds htmlMain

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b6d6d10 View commit details
    Browse the repository at this point in the history

  2. Add useRefInit

    @greglittlefield-wf
    greglittlefield-wf committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1a6161a View commit details
    Browse the repository at this point in the history