Fixed block particle duplication bug #24
Conversation
| @@ -119,6 +119,15 @@ public static WorldView createWorldView(int dimid, ChunkCoordinates spawn, int w | |||
| EntityLivingBase backup = mc.renderViewEntity; | |||
| mc.renderViewEntity = view.camera; | |||
| view.getRenderGlobal().setWorldAndLoadRenderers(proxyworld); | |||
| if(proxyworld.provider.dimensionId == Minecraft.getMinecraft().thePlayer.dimension) { | |||
| proxyworld.removeWorldAccess(view.getRenderGlobal()); | |||
There was a problem hiding this comment.
Formatting error. Please correct and squash. :)
|
Looks good! :D Are there any side effect to removing and readding the renderer every frame? |
… dimension as the player
|
Ah, yeah, that would be better, lol. What was the logic you were thinking of? I can hopefully test it out. |
|
It's been a year, nearly, so I don't remember the exact location or if it is still in, but I recall a section of code detecting Overworld world changes (by comparison) and handling world changes somewhere. I feel the detection was probably in the ProxyWorldManager, though I think the handling was called from there and somewhere else. You shouldn't have to look far from this class, really. |
This fixes the block-breaking duplication bug that occurs when there is a view in the same dimension as the player.