Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GrpcSource for ETL ng #1745

Merged
merged 6 commits into from
Nov 21, 2024

Merge branch 'develop' into feature/etl-grpcsource-ng

0594ecb
Select commit
Loading
Failed to load commit list.
Merged

feat: GrpcSource for ETL ng #1745

Merge branch 'develop' into feature/etl-grpcsource-ng
0594ecb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 1s

71.71% (target 50.00%)

View this Pull Request on Codecov

71.71% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 73.05389% with 45 lines in your changes missing coverage. Please review.

Project coverage is 71.71%. Comparing base (9dc322f) to head (0594ecb).

Files with missing lines Patch % Lines
src/etlng/impl/AsyncGrpcCall.cpp 72.00% 10 Missing and 11 partials ⚠️
src/etlng/impl/GrpcSource.cpp 71.64% 8 Missing and 11 partials ⚠️
src/web/Resolver.cpp 82.60% 2 Missing and 2 partials ⚠️
src/web/dosguard/WhitelistHandler.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1745      +/-   ##
===========================================
- Coverage    71.71%   71.71%   -0.01%     
===========================================
  Files          292      295       +3     
  Lines        12487    12649     +162     
  Branches      6359     6471     +112     
===========================================
+ Hits          8955     9071     +116     
- Misses        1848     1870      +22     
- Partials      1684     1708      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov