Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoBump] Merge with fixes of 693ba938 (Jun 17) (10) (needs LLVM bump Jun 11) #174

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

cferry-AMD
Copy link

@cferry-AMD cferry-AMD commented Aug 26, 2024

Needs Xilinx/llvm-project#335

commit 0fb216fb2fbb49c1fe90c1c3267873a100b1c356
Author: Ramkumar Ramachandra <[email protected]>
Date:   Tue Jun 11 23:00:02 2024 +0100

    mlir/MathExtras: consolidate with llvm/MathExtras (#95087)
    
    This patch is part of a project to move the Presburger library into
    LLVM.

Original ONNX-MLIR wants commit c012e487b7:

commit c012e487b7246239c31bd378ab074fb110631186
Author: Johannes de Fine Licht <[email protected]>
Date:   Wed Jun 12 08:29:02 2024 +0200

    [MLIR][LLVM] Promote noinline/alwaysinline/optnone out of passthrough (#95110)
    
    The `noinline`, `alwaysinline`, and `optnone` function attributes are
    already being used in MLIR code for the LLVM inlining interface and in
    some SPIR-V lowering, despite residing in the passthrough dictionary,
    which is intended as exactly that -- a pass through MLIR -- and not to
    model any actual semantics being handled in MLIR itself.
    
    Promote the `noinline`, `alwaysinline`, and `optnone` attributes out of
    the passthrough dictionary on `llvm.func` into first class unit
    attributes, updating the import and export accordingly.
    
    Add a verifier to `llvm.func` that checks that these attributes are not
    set in an incompatible way according to the LLVM specification.
    
    Update the LLVM dialect inlining interface to use the first class
    attributes to check whether inlining is possible.

mikeessen and others added 2 commits June 17, 2024 07:27
* Update LLVM to c012e487b724

Signed-off-by: Mike Essenmacher <[email protected]>

* Update big endian lit test

Signed-off-by: Mike Essenmacher <[email protected]>

---------

Signed-off-by: Mike Essenmacher <[email protected]>
@cferry-AMD cferry-AMD changed the base branch from bump_to_0831202d to bump_to_8b316566 August 26, 2024 13:23
@cferry-AMD cferry-AMD changed the title [AutoBump] Merge with fixes of 693ba938 (Jun 17) (9) [AutoBump] Merge with fixes of 693ba938 (Jun 17) (9) (needs LLVM bump) Aug 26, 2024
@cferry-AMD cferry-AMD requested a review from mgehre-amd August 26, 2024 13:25
@cferry-AMD cferry-AMD changed the title [AutoBump] Merge with fixes of 693ba938 (Jun 17) (9) (needs LLVM bump) [AutoBump] Merge with fixes of 693ba938 (Jun 17) (9) (needs LLVM bump Jun 11) Aug 26, 2024
@mgehre-amd mgehre-amd changed the title [AutoBump] Merge with fixes of 693ba938 (Jun 17) (9) (needs LLVM bump Jun 11) [AutoBump] Merge with fixes of 693ba938 (Jun 17) (10) (needs LLVM bump Jun 11) Aug 26, 2024
@cferry-AMD cferry-AMD marked this pull request as draft August 27, 2024 05:53
@cferry-AMD
Copy link
Author

Marking as draft to back off from working on this until we've got the LLVM bump

Base automatically changed from bump_to_8b316566 to bump_to_0831202d August 29, 2024 09:00
An error occurred while trying to automatically change base from bump_to_8b316566 to bump_to_0831202d August 29, 2024 09:00
@mgehre-amd mgehre-amd marked this pull request as ready for review August 29, 2024 09:02
Base automatically changed from bump_to_0831202d to feature/onnx-to-tosa September 2, 2024 08:49
@cferry-AMD cferry-AMD merged commit c0033eb into feature/onnx-to-tosa Sep 12, 2024
8 checks passed
@cferry-AMD cferry-AMD deleted the bump_to_693ba938 branch September 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants