rtlil: Speeds up Yosys by 17%

This PR speeds up by roughly 17% across a wide spectrum of designs tested at Google. Particularly for the mux generation pass. Co-authored-by: Rasmus Larsen <[email protected]> Signed-off-by: Ethan Mahintorabi <[email protected]>
YosysHQ · Sep 21, 2023 · aa06809 · aa06809
1 parent c4762d9
commit aa06809
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/kernel/rtlil.cc b/kernel/rtlil.cc
@@ -4031,16 +4031,20 @@ void RTLIL::SigSpec::replace(const RTLIL::SigSpec &pattern, const RTLIL::SigSpec
 	unpack();
 	other->unpack();
 
+	dict<RTLIL::SigBit, int> pattern_to_with;
 	for (int i = 0; i < GetSize(pattern.bits_); i++) {
 		if (pattern.bits_[i].wire != NULL) {
-			for (int j = 0; j < GetSize(bits_); j++) {
-				if (bits_[j] == pattern.bits_[i]) {
-					other->bits_[j] = with.bits_[i];
-				}
-			}
+			pattern_to_with.emplace(pattern.bits_[i], i);
 		}
 	}
 
+	for (int j = 0; j < GetSize(bits_); j++) {
+		auto it = pattern_to_with.find(bits_[j]);
+		if (it != pattern_to_with.end()) {
+			other->bits_[j] = with.bits_[it->second];
+		}
+	}
+
 	other->check();
 }