Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mem: Fix index confusion in write port merging #3928

Merged
merged 1 commit into from
Sep 12, 2023
Merged

mem: Fix index confusion in write port merging #3928

merged 1 commit into from
Sep 12, 2023

Conversation

povik
Copy link
Member

@povik povik commented Sep 12, 2023

Fix mistaking the read-port and write-port indices for each other when we are adding the partial transparency emulation to be able to merge two write ports.

@povik
mem: Fix index confusion in write port merging
cbc4ec8 
Fix mistaking the read-port and write-port indices for each other when
we are adding the partial transparency emulation to be able to merge two
write ports.
@povik povik requested a review from mwkmwkmwk September 12, 2023 14:44
mwkmwkmwk
mwkmwkmwk approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@mwkmwkmwk mwkmwkmwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find, thanks

@povik povik merged commit b04f235 into YosysHQ:master Sep 12, 2023
15 checks passed
@povik povik mentioned this pull request Sep 13, 2023
Merged
@povik povik deleted the mem-wr-merge-transpemu-fix branch October 9, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwkmwkmwk mwkmwkmwk mwkmwkmwk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povik @mwkmwkmwk