Speed up the autoname pass by 3x. #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucting IdString objects for plain strings that have a higher score.
|
Hang on. I think this will be even faster if we keep them as plain strings until after we pull them out of the proposed_*_names maps. Let me update this. |
rmlarsen
changed the title
Yup, that makes this a 3x instead of a 2x speedup. |
|
OK, this is ready for review. |
whitequark
approved these changes
Sep 21, 2023
gussmith23
pushed a commit
to uwsampl/yosys
that referenced
this pull request
Nov 20, 2023
* Speed up the autoname pass by 2x. This is accomplished by only constructing IdString objects for plain strings that have a higher score. * Defer creating IdStrings even further. This increases the speedup to 3x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished by only constucting IdString objects from plain strings that have a higher score.
Before:
After:
