gowin: fix abc9 attributes and specify blocks #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepijndevos
approved these changes
Oct 3, 2023
|
@mmicko did I break something? Jenkins complains but the error is somewhere inside sby? |
|
Oh, is this what the very latest commit on master fixes? |
|
@Ravenslofty it is fine, just please rebase on master, there is fix already for error |
Ravenslofty
force-pushed
the
lofty/gowin-dff
branch
from
9f5d1c5 to
2948441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A certain past wolfenby wrote a bunch of sequential paths in
specifyblocks to describe asynchronous sets/resets withinabc9_boxcells, which require combinational paths. This horrifically broke ABC9 flows, and I apologise.While I was here, I took the liberty of turning some fully-synchronous cells into
abc9_floprather thanabc9_box, which will likely help sequential synthesis (if somebody asks me nicely to implement that).cc @pepijndevos @yrabbit