Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim: Evaluate all cells once #4044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

povik
Copy link
Member

@povik povik commented Nov 27, 2023

If a cell starts with undefined inputs and the value of those inputs is never changed, sim code will never evaluate that cell. This means its output will be left at undefined, but in some edge cases such cell can evaluate to a defined value. To address those cases evaluate all cells at least once.

@povik
Copy link
Member Author

povik commented Nov 27, 2023

One way this can be hit in practice is when some of the memory_* passes emit $eq cells comparing zero-sized signals, and those are not removed by opt_expr before sim is ran.

If a cell starts with undefined inputs and the value of those inputs is
never changed, `sim` code will never evaluate that cell. This means its
output will be left at undefined, but in some edge cases such cell can
evaluate to a defined value. To address those cases evaluate all cells
at least once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant