quicklogic: Generate bram_types_sim.v at build time
#4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmicko
reviewed
Dec 4, 2023
techlibs/quicklogic/Makefile.inc
Outdated
| @@ -1,6 +1,9 @@ | |||
| %_pm.h: passes/pmgen/pmgen.py %.pmg | |||
| $(P) mkdir -p pmgen && $(PYTHON_EXECUTABLE) $< -o $@ -p $(subst _pm.h,,$(notdir $@)) $(filter-out $<,$^) | |||
|
|
|||
| techlibs/quicklogic/qlf_k6n10f/bram_types_sim.v: techlibs/quicklogic/qlf_k6n10f/generate_bram_types_sim.py | |||
| $(P) python3 $^ $@ | |||
There was a problem hiding this comment.
Use $(PYTHON_EXECUTABLE) here instead of python3
povik
force-pushed
the
ql-bram_types-gen
branch
from
eb103a2 to
e0fc48e
Compare
mmicko
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source tree has a checked-in version of
bram_types_sim.veven though that's a file that is automatically generated. Check out the file from version control, and instead add rules to generate the file on-demand.By making sure the generated file is up-to-date, this fixes
raised by