Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxxrtl: Remove redundant divmod #4061

Merged
merged 2 commits into from
Dec 9, 2023
Merged

cxxrtl: Remove redundant divmod #4061

merged 2 commits into from
Dec 9, 2023

Conversation

merryhime
Copy link
Contributor

Self-explanatory.

@merryhime merryhime requested a review from whitequark as a code owner December 9, 2023 14:13
whitequark
whitequark requested changes Dec 9, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

backends/cxxrtl/runtime/cxxrtl/cxxrtl.h Outdated Show resolved Hide resolved
backends/cxxrtl/runtime/cxxrtl/cxxrtl.h Outdated Show resolved Hide resolved
whitequark
whitequark approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@whitequark whitequark merged commit 0681baa into YosysHQ:master Dec 9, 2023
14 of 16 checks passed
@merryhime merryhime deleted the dedup-divmod branch December 9, 2023 22:48
@povik
Copy link
Member

povik commented Dec 11, 2023

I think this change has made the tests/fmt/always_comb_tb.cc test hang, making CI jobs on master stuck. I am looking into it.

@povik
Copy link
Member

povik commented Dec 11, 2023

Hang appears to be fixed by #4067

@povik povik mentioned this pull request Dec 12, 2023
Merged
@povik povik mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merryhime @povik @whitequark