cxxrtl: Use the base name of the interface file for the include directive #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive Prior to this fix, the `CxxrtlBackend` used the entire path for the include directive when a separated interface file is generated (via the `-header` option). This commit updates the code to use the base name of the interface file. Since the C++11 standard is used by default, we cannot take advantage of the `std::filesystem` to get the basename.
whitequark
reviewed
Dec 11, 2023
Henkru
force-pushed
the
fix/cxxrtl-header-basename
branch
from
8245f40 to
ceed04b
Compare
whitequark
reviewed
Dec 11, 2023
whitequark
approved these changes
Dec 11, 2023
povik
reviewed
Dec 11, 2023
povik
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where an incorrect include file name is generated for the
.ccfile when using the-headerflag and the filename includes folders.For example:
The following files are created:
build/top.handbuild/top.cc. Thetop.cchas the following include directive to include thetop.h:It should instead be: