Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lattice: Fix mapping onto DP8KC for data width 1 or 2 #4087

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

povik
Copy link
Member

@povik povik commented Dec 20, 2023

This appears to be the right wiring of DP8KC per the MachXO3 simulation model I have at hand.

Some points:

  • I don't know if this applies to all DP8KCprimitives across the Lattice families.

  • Reading into the simulation model, it seems one cannot map a memory with write port of width 18 and read port of width 2 onto DP8KC. This is because DIB1, which would be used for the 10th data bit input, gets ignored. If this is true, or even if it's just a bug of the simulation model, we may want to disable this configuration in libmap inference of $__PDPW8KC_. UPDATE: done in the second commit

@povik povik requested a review from mmicko December 21, 2023 09:49
Copy link
Member

@mmicko mmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also regarding open points, we are sure this same primitive is used on all XO2/3/3D models, and their simulation models and mappings are same.

@mmicko mmicko merged commit 86b8a1c into YosysHQ:master Dec 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants