Fix Windows build by forcing initialization order, fixes #4068 #4101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows build is crashing on start, since registering of passes crashed. IdString can not be used as variable default values since order of initialization is not guaranteed, and MinGW compiler always doing it in different order than Clang.
Using
static
is not strictly necessary but makes sure to do this only once per run.Have tried to make this with less changes as possible, but guess
m_
prefix for variables should be removed since they are local.FYI doing init as part of constructor initialization does not help, since that is actually same moment of execution as previous code.