Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct hierarchical path names for structs and unions #4104

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Correct hierarchical path names for structs and unions #4104

merged 1 commit into from
Jan 5, 2024

Conversation

daglem
Copy link
Contributor

@daglem daglem commented Jan 4, 2024

No description provided.

@daglem daglem requested a review from zachjs as a code owner January 4, 2024 16:22
whitequark
whitequark approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a welcome improvement! I would like a second pair of eyes on the diff though.

zachjs
zachjs approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@zachjs zachjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right. Thanks for fixing this!

@povik povik merged commit c72dc15 into YosysHQ:master Jan 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachjs zachjs zachjs approved these changes

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daglem @whitequark @zachjs @povik