opt_clean: Add commentary, remove dead code #4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povik
commented
Jan 9, 2024
| @@ -418,6 +438,9 @@ bool rmunused_module_signals(RTLIL::Module *module, bool purge_mode, bool verbos | |||
| goto delete_this_wire; | |||
| } else | |||
| if (!used_signals.check_any(s2)) { | |||
| // this path shouldn't be possible: this wire is used directly (otherwise it would get cleaned up above), and indirectly | |||
| // used wires are a superset of those used directly | |||
| log_assert(false); | |||
There was a problem hiding this comment.
I pushed the commits piecemeal so there's a CI job with this assertion in place.
povik
force-pushed
the
clean-opt_clean
branch
from
b865f8d to
7afc069
Compare
|
Rebased and dropped the final patch removing the assertion. To play it safe we plan to keep the assertion in for a release or two. Removal of the assertion is staged in #4169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a by-product of investigating the hang from #4118.)
See the commits.