gowin: Change BYTE ENABLE handling. #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inferring we allow writing to all bytes for now.
In the Gowin documentation for BSRAM 2019, the byte_enable port and its operation and use in generating IP with pictures were described in detail, two years later in the same document the byte_enable port was listed as supported only for the NS-2 family, and finally in the 2023 edition, all references to both the NS-2 family and the byte_enable port were removed.
I don’t know, maybe it turned out that they forgot the transistor there and it works unstable or something else, but at the moment I’m thinking of using only fixed values when inferring. You can use anything manually - after all, these are just lsb addresses.