Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the XDG Base Directory Specification #4190

Merged
merged 15 commits into from
Feb 8, 2024
Merged

Follow the XDG Base Directory Specification #4190

merged 15 commits into from
Feb 8, 2024

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Feb 8, 2024

Expands #4093 PR by moving code and display messages only if used with debug parameter, since yosys is fully functional without setting variables, and also history is only useful in interactive mode, and logs could spam users using it for scripting.

@mmicko mmicko requested a review from nakengelhardt February 8, 2024 10:41
@nakengelhardt
Copy link
Member

As a side effect, if -g is not used and it can't create the file, this now prints <suppressed ~1 debug messages> after the first command that you run. This is a bit misleading since it happened before the first command, should we call log_suppressed() before, e.g. in yosys_setup()? That would print it before the first prompt which is more suitable IMO:

 /----------------------------------------------------------------------------\
   <header snipped>
 \----------------------------------------------------------------------------/

 Yosys 0.37+90 (git sha1 2797d6756, clang 15.0.0 -fPIC -Os)

<suppressed ~1 debug messages>

yosys>

@nakengelhardt
Copy link
Member

Actually, maybe driver.cc:593 (after load_plugin) would be an even better place to put it, that way it accommodates plugins using log_debug during registration as well.

@mmicko mmicko merged commit 675b8a7 into master Feb 8, 2024
34 checks passed
@mmicko mmicko deleted the xdg branch February 8, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants