Added to the Show command a -wireshape <graphviz-shape> flag. #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to control the shape of wire nodes, for example, -wireshape plaintext. The motivation is to allow the user to reduce visual loads of wires. This does not change the default behavior of using a diamond shape.
|
@povik, is this build failure related to my change? |
|
I don't think so. Pinging @whitequark, maybe she will know right away. |
|
Build failure is due to latest release of emscripten. #4255 fixes it :) |
|
Will this be retried automatically now that #4255 is in? |
|
You’ll need to rebase it on latest master to get the fix.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the flag
-wireshape <graphviz-shape>to the Show command and allows to control the shape of wire nodes in the generated graph. The default behavior of using a diamond shape stays the same. The motivation is to allow users to reduce the visual load of wires.Before (also the new default behavior and with -wireshape diamond)
After, with -wireshape plaintext.
Dot files
Archive.zip