Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default CONFIG to none #4270

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Change default CONFIG to none #4270

merged 4 commits into from
Mar 25, 2024

Conversation

KrystalDelusion
Copy link
Member

Default to using provided CXX (either via environment variable or make).

Some of the ifeq ($(CONFIG), ..) checks might also be worth changing to check $(CXX) instead to, e.g. use a clang sanitizer if one is selected without config-clang.

Makefile Outdated Show resolved Hide resolved
- Use default value of `CXX` instead of forcing override to `clang++`.
- Add base `CXXFLAGS` and `ABCMKARGS` in else condition of `ifeq ($(CONFIG),..)`
  block and output the value of `CXX`.
- Change readme to mention `CXX` envvar and that using `make config-clang` etc
  will ignore `CXX`.
@mmicko
Copy link
Member

mmicko commented Mar 11, 2024

This changes default behavior since now CXX is detected and on Linux it gets defaulted to g++, and current Makefile is enforcing clang by default.

Suggest removing -Wno-c++11-narrowing from Makefile since that will make ABCMKARGS behave same on gcc and clang config paths. (best checking building abc by removing abc directory before build)

@whitequark
Copy link
Member

This changes default behavior since now CXX is detected and on Linux it gets defaulted to g++, and current Makefile is enforcing clang by default.

To be honest it was pretty weird that clang would be picked by default even on Linux (I strongly prefer clang but it's still weird).

@KrystalDelusion
Copy link
Member Author

This changes default behavior since now CXX is detected and on Linux it gets defaulted to g++, and current Makefile is enforcing clang by default.

There's nowhere that actually says what the default compiler is, just that running make config-* was necessary for a specific compiler so I don't think that's a problem. And as someone who prefers clang I would always run make config-clang on a fresh install, having assumed until making this PR that gcc would be the default.

@mmicko mmicko merged commit c9d9b9e into main Mar 25, 2024
34 checks passed
@mmicko mmicko deleted the krys/config-none branch March 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build yosys in Ubuntu following instructions in README
3 participants