extract: add arbitrary port width matching #4304
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use minimum port width from solver - copy over WIDTH and SIGNED parameters to new cell
povik
reviewed
Mar 28, 2024
passes/techmap/extract.cc
Outdated
| @@ -427,6 +438,10 @@ struct ExtractPass : public Pass { | |||
| log(" -mine_max_fanout <num>\n"); | |||
| log(" don't consider internal signals with more than <num> connections\n"); | |||
| log("\n"); | |||
| log(" -min_port_width <num>\n"); | |||
| log(" match all subcircuits with port-sizes between needle port widths and this number\n"); | |||
There was a problem hiding this comment.
So "this number" is lower than the needle port widths?
There was a problem hiding this comment.
Yes, this number defines the lower bounds of the needle port width (it applies to all ports).
Usually the port widths must match exactly, this exposes an existing feature of the algorithm.
So: hay_port_width ∈ [min_width; needle_port_width]
There was a problem hiding this comment.
Yes, I am asking due to the phrasing, which suggested to me <num> is an upper bound, not a lower bound. Not sure what we should change it to though.
There was a problem hiding this comment.
maybe something like:
match all subcircuits with port widths from <num> up to the needle port width given in the map.
This does not yet seem to work completely as intended. The idea is to trim the port widths of the extracted circuits, so that it does not leave X bits as padding at the MSBs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to improve extract and make it easier to use in scenarios similar to the ones described in the extract example.
The final goal is to extract something like a multiplier followed by an arbitrary amount of variable-width adders.
ToDo:
'Zmaccexamples