Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxxrtl: Fix sdivmod #4305

Merged
merged 1 commit into from
Mar 30, 2024
Merged

cxxrtl: Fix sdivmod #4305

merged 1 commit into from
Mar 30, 2024

Conversation

merryhime
Copy link
Contributor

x = x.neg(); results in the subsequent x.is_neg() to always be false.
Ditto for the dividend.is_neg() != divisor.is_neg() test.
Fix this.

x = x.neg(); results in the subsequent x.is_neg() always being false.
Ditto for the dividend.is_neg() != divisor.is_neg() test.
@merryhime merryhime requested a review from whitequark as a code owner March 29, 2024 20:55
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark merged commit d07a55a into YosysHQ:main Mar 30, 2024
17 checks passed
@merryhime merryhime deleted the cxxrtl-fixes-2 branch March 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants