Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ast ternary string extension #4319

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Khrig
Copy link

@Khrig Khrig commented Apr 4, 2024

@jix
Copy link
Member

jix commented Apr 8, 2024

As discussed during the Dev JF, there are some subtleties with strings in SV as it defines a dynamically sized string type (6.16) as well as implicitly zero pads string literals in a non string context (11.10), it's not obvious how this interacts with the rather complex rules of the conditional operator (11.4.11) for all possible edge cases.

Before merging a fix I'd like to have a more extensive set of test cases to make sure we fully understand what the standard specifies and to compare whatever fix we end up using with the behavior implemented by other tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants