Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce action spam when a PR source branch is on YosysHQ/yosys #4364

Merged
merged 8 commits into from
May 9, 2024

Conversation

KrystalDelusion
Copy link
Member

@KrystalDelusion KrystalDelusion commented Apr 29, 2024

Introduce fkirc/skip-duplicate-actions to skip duplicate action runs.
Also remove deprecated emcc.yml.

@KrystalDelusion KrystalDelusion force-pushed the krys/skip-duplicate-actions branch from b520a19 to ab7e5b3 Compare April 30, 2024 00:01
@KrystalDelusion KrystalDelusion marked this pull request as ready for review April 30, 2024 00:33
@KrystalDelusion KrystalDelusion requested a review from mmicko as a code owner April 30, 2024 00:33
Copy link
Member

@mmicko mmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine regarding functionality.

Please just rebase/resolve conflicts since there were changes in files. Note that this configuration change was needed for abc as submodule 09b9aa8

Also emcc.yml could be fully removed as agreed on meeting so that can be part of this PR as well.

Currently only vs.yml and wasi.yml since emscripten is on the chopping block.
Use fkirc/skip-duplicate-actions to skip duplicate action runs.
@KrystalDelusion KrystalDelusion force-pushed the krys/skip-duplicate-actions branch from c3d8ba5 to a9eca90 Compare May 8, 2024 21:28
@KrystalDelusion KrystalDelusion requested a review from mmicko May 8, 2024 22:13
@mmicko mmicko merged commit 514852a into main May 9, 2024
32 checks passed
@mmicko mmicko deleted the krys/skip-duplicate-actions branch May 9, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants