Only build yosys-abc usage docs when ABCEXTERNAL is not set #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 0.41, when building docs with ABCEXTERNAL set, the rule for yosys-abc docs usage would attempt to build in-tree ABC. This fix this regression by only including yosys-abc in DOCS_USAGE_STDERR when ABCEXTERNAL is not set. Signed-off-by: Mary Guillemard <[email protected]>
Ravenslofty
approved these changes
May 22, 2024
|
How does this affect the auxiliary programs docs page? |
Before #4334, it would generate an empty usage silently for With my changes it match previous behavior Here is the pdf side generated with |
KrystalDelusion
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4334, when building docs with
ABCEXTERNALset, the rule for yosys-abc docs usage would attempt to build in-tree ABC.This fix this regression by only including yosys-abc in
DOCS_USAGE_STDERRwhenABCEXTERNALis not set.