libs/fst: Update from upstream #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrystalDelusion
force-pushed
the
update_fst
branch
3 times, most recently
from
2b4d5c8 to
f2e5015
Compare
KrystalDelusion
force-pushed
the
update_fst
branch
2 times, most recently
from
139f81c to
e2a6d47
Compare
Add shell script (based on minisat lib) to clone and copy relevant files. Unclear if there are any changes lost that we need to patch back in.
I think what's happening here is that the _WIN64 fix is correct for 64bit windows, but (for whatever reason) the visual studio build is targeting 32bit windows, so the fix is unnecessary, but the upstream fix doesn't expect to be targeting 32bit windows and assumes all windows builds are 64bit... so fix that.
KrystalDelusion
force-pushed
the
update_fst
branch
from
e2a6d47 to
2157f67
Compare
|
Windows build (or rather, vs build) now completes successfully, but it doesn't run any tests, and I'm not sure if we have any tests for fst. |
|
Can confirm that tests are passing on Windows machine when build done by mingw. |
KrystalDelusion
added
the
merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
#4541 (comment)
i.e. why don't we track upstream fstapi
Explain how this is achieved.
Add and run shell script (based on minisat lib) to clone and copy relevant files.
If applicable, please suggest to reviewers how they can test the change.
Need to check if there are any changes lost that we need to patch back in.