internal_stats: init, report current memory consumption on linux and mac #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widlarizer
force-pushed
the
emil/devstat
branch
from
686ae62 to
a165267
Compare
widlarizer
changed the title
widlarizer
force-pushed
the
emil/devstat
branch
from
a165267 to
6f8030e
Compare
widlarizer
force-pushed
the
emil/devstat
branch
from
6f8030e to
0ce7631
Compare
povik
approved these changes
Sep 3, 2024
| log("{\n"); | ||
| log(" \"creator\": %s,\n", json11::Json(yosys_version_str).dump().c_str()); | ||
| std::stringstream invocation; | ||
| std::copy(args.begin(), args.end(), std::ostream_iterator<std::string>(invocation, " ")); |
There was a problem hiding this comment.
I think it's best to serialize that as a list
There was a problem hiding this comment.
I just copy pasted that from the json backend
| void help() override | ||
| { | ||
| // |---v---|---v---|---v---|---v---|---v---|---v---|---v---|---v---|---v---|---v---| | ||
| log("\n"); // TODO |
There was a problem hiding this comment.
Help missing, not something we should let into a release
There was a problem hiding this comment.
TIL empty help messages causes docs to fail (granted it is technically a warning, but warnings are errors in our ReadtheDocs setup)
/home/docs/checkouts/readthedocs.org/user_builds/yosys/checkouts/latest/docs/source/cmd/internal_stats.rst:21: WARNING: Literal block expected; none found. [docutils]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To find out static memory usage right after RTLIL generation and at other points in the flow, currently the best practice is to dump and reload and inspect peak memory usage. This PR adds the experimental
devstatcommand that prints in a JSON format the current memory usage. It is intended to be expanded further for information about the efficiency of RTLIL object representation and anything else that's relevant to yosys developers but not users.On linux, yosys inspects its
/proc/self/statusfile. This may not be present on some Linux distributions, but it should be handled gracefully should that file not exist.On macOS, I use task_info
-jsonisn't used