Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/yosys-config.in: don't use the non-portable '==' operator with test(1) #4666

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

thorpej
Copy link
Contributor

@thorpej thorpej commented Oct 14, 2024

What are the reasons/motivation for this change?
The '==' operator is non-standard and does not work with all versions of test(1) or sh(1).

Explain how this is achieved.
The fix is simple: use the standard '=' operator instead.

If applicable, please suggest to reviewers how they can test the change.
Ensure yosys builds.

Resolves issue #4665.

@widlarizer
Copy link
Collaborator

The file is shebanged with #/usr/bin/env bash and bash on different platforms should be consistent, I'm not really sure how does sh come into play here, but since = and == is strictly equivalent in bash, this PR is good to go

@widlarizer widlarizer merged commit d1695ad into YosysHQ:main Oct 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants