Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py_wrap: implement nested class definitions #4671

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

widlarizer
Copy link
Collaborator

Fixes #4670 by probably implementing nested class declaration. I don't really know what the wrapper generator does and I don't want to find out more than I already did. Also the DIY C++ parser doesn't like trailing commas in enum declarations so I removed it from RTLIL::ConstFlags.

@povik
Copy link
Member

povik commented Oct 17, 2024

Is there a diff in the generator's output against what it produced the last time it worked?

@widlarizer
Copy link
Collaborator Author

Here you go. The diff is the const additions and then temporary variable naming noise

python_wrappersnew.txt
python_wrappersold.txt

@povik
Copy link
Member

povik commented Oct 18, 2024

The flags property seems to have disappeared

@widlarizer
Copy link
Collaborator Author

short -> short int fixes that

@povik
Copy link
Member

povik commented Oct 18, 2024

Not the change I expected to help

Copy link
Member

@povik povik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generator output looks good so I think we can merge this

@widlarizer widlarizer merged commit 799497e into main Oct 18, 2024
37 of 38 checks passed
@mmicko mmicko deleted the emil/const-deref-pyosys branch October 21, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyosys build breaks: Const has no member named 'operator*'
2 participants