-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py_wrap: implement nested class definitions #4671
Conversation
Is there a diff in the generator's output against what it produced the last time it worked? |
Here you go. The diff is the const additions and then temporary variable naming noise |
The flags property seems to have disappeared |
|
Not the change I expected to help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generator output looks good so I think we can merge this
Fixes #4670 by probably implementing nested class declaration. I don't really know what the wrapper generator does and I don't want to find out more than I already did. Also the DIY C++ parser doesn't like trailing commas in enum declarations so I removed it from
RTLIL::ConstFlags
.