Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel/drivertools.h: avoid maybe-uninitialized compile warnings #4721

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

ldoolitt
Copy link
Contributor

@ldoolitt ldoolitt commented Nov 8, 2024

Initialize "unsigned int inner" in hash() functions
Includes a log_assert() that might help catch corrupted data structures or future incomplete modification of DriveType definition

See Issue #4713, Reduce compiler warnings when building yosys

Initialize "unsigned int inner" in hash() functions
Includes a log_assert() that might help catch corrupted data structures
or future incomplete modification of DriveType definition
@KrystalDelusion
Copy link
Member

Huh, this actually doesn't affect the number of warnings in the git actions. I wonder if this is because we only test gcc-10 and gcc (which is apparently gcc-11) where your issue mentions gcc-12. Could indicate that we could/should declare a newer gcc target.

@ldoolitt
Copy link
Contributor Author

ldoolitt commented Nov 8, 2024

Huh, this actually doesn't affect the number of warnings in the git actions. I wonder if this is because we only test gcc-10 and gcc (which is apparently gcc-11) where your issue mentions gcc-12. Could indicate that we could/should declare a newer gcc target.

gcc-12 is default in Debian Stable, so not exactly bleeding-edge. I'm starting to test code with gcc-14 in Debian Testing, which is likely to ship (as the new Stable) next Spring.

@KrystalDelusion KrystalDelusion added the merge-after-jf Merge: PR will be merged after the next Dev JF unless concerns are raised label Nov 10, 2024
@povik povik merged commit 1717a0b into YosysHQ:main Nov 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-after-jf Merge: PR will be merged after the next Dev JF unless concerns are raised
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants