Add a Han-Carlson option for $lcu mapping
#4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povik
approved these changes
Nov 28, 2024
tests/techmap/kogge-stone.tcl
Outdated
| design -load init | ||
| chparam -set WIDTH $i | ||
| yosys proc | ||
| equiv_make -blacklist ppa.nomatch lcu _80_lcu_kogge_stone equiv |
There was a problem hiding this comment.
The fact that this matches on internal names makes me think we are using the wrong command to check equivalence here
There was a problem hiding this comment.
looks like the folklore is opt_clean before equiv_make
widlarizer
changed the title
$lcu mapping$lcu mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Han-Carlson parallel-prefix adder (PPA) is an adder construction for ASIC use with an attractive tradeoff. We expect similar delay to Kogge-Stone PPA but better area. I have implemented it in the same procedural style as the current Kogge-Stone and Brent-Kung PPAs. I'm testing it by proving equivalence with
equiv_simplefor bit widths from 1 to 16. I have additionally replaced the test for Kogge-Stone with the same approach. To sweep a variable, full TCL scripting is necessary, which Yosys supports. This PR adds support for using TCL scripts in tests. The HC-PPA and KS-PPA tests take 120ms and 95ms on my Zen 4 machine, respectively.I'm not really sure what to do with the priority integer at the beginning of the module name. Reviewers may test the tests by locally modifying the designs and watching the tests fail