Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapcell: Optionally track unused outputs #4799

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

povik
Copy link
Member

@povik povik commented Dec 5, 2024

What are the reasons/motivation for this change?

Provide the option for wrapcell to generate wrapper modules with unused ports removed. In the motivating use case for this command which is preserving arithmetic operator boundaries this helps with QoR.

@povik povik requested a review from widlarizer December 9, 2024 14:11
Copy link
Collaborator

@widlarizer widlarizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pass seems to work well but more context on the implementation would be welcome

passes/cmds/wrapcell.cc Show resolved Hide resolved
passes/cmds/wrapcell.cc Show resolved Hide resolved
passes/cmds/wrapcell.cc Show resolved Hide resolved
passes/cmds/wrapcell.cc Show resolved Hide resolved
@povik povik requested a review from widlarizer December 10, 2024 14:14
@povik povik merged commit 4bd6061 into YosysHQ:main Dec 10, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants