Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_liberty: Revisit for abc9 whiteboxes #4804

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

povik
Copy link
Member

@povik povik commented Dec 5, 2024

What are the reasons/motivation for this change?

Make two changes which make it easier to use boxes loaded in by read_liberty for abc9 boxes: Attach the simple_comb_cell attribute on box definitions which are purely combinational and have simple input/output pins. Also redo the -unit_delay mode to: avoid reading the timing_type attribute (which is optional) and avoid needing to deal with arcs from an output pin to an output pin.

@widlarizer widlarizer self-requested a review December 9, 2024 14:17
@povik povik marked this pull request as draft December 9, 2024 14:34
@povik
Copy link
Member Author

povik commented Dec 9, 2024

Pending change: setting abc9_box instead of the simple_comb_cell attribute

@povik
Copy link
Member Author

povik commented Dec 9, 2024

Pending change: setting abc9_box instead of the simple_comb_cell attribute

Done

@povik povik marked this pull request as ready for review December 9, 2024 14:46
Copy link
Collaborator

@widlarizer widlarizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@povik povik merged commit e9c7967 into YosysHQ:main Dec 10, 2024
26 checks passed
@povik povik deleted the read_liberty-comb-cells branch December 10, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants