Stop and prevent discarding hash_into values #4848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously at some point when finishing #4524 I accidentally discarded the hashing result in the
hash_obj_opsimplementation. I'm fixing that here and marking allhash_intoandhash_topmethods[[nodiscard]]. Prior to this PR, any non-trivial design would runopt_cleanfor excessive amounts of time since allCell*andWire*hashes would collide. To test the impact, you can compare the perf of the PR head against the root commit of this PR branch (6225abe) and the main commit prior to the hashlib PR merge (7a362f1).Once again, reviewers are automatically set to code owners and I can't remove those, sorry for the spam.